Subscribe stop crash #13034
Merged
Subscribe stop crash #13034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @perbergland. Some tests are failing, but maybe it is just a matter of rerunning them. Could you merge the release-3.0 branch here again? Let's see if the tests are going to pass. I tried to merge release-3.0 here, but I cannot commit to your fork. |
denihs
requested changes
Mar 6, 2024
Grubba27
approved these changes
Mar 7, 2024
denihs
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13028 and adds validation to catch more errors.
I suspect there are plenty more missing awaits, but at least these a few are fixed here.
Also turned var's into const's because it needs to be done some day.
I tried to preserve the sequence of calls between the constructor and the async _init method