New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue with methods interacting with unblocking mechanisms #13055
Merged
+38
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachocodoner
commented
Mar 6, 2024
Merged
nachocodoner
changed the title
Fix an issue with method interacting with unblocking mechanisms
Fix an issue with methods interacting with unblocking mechanisms
Mar 7, 2024
Grubba27
approved these changes
Mar 7, 2024
zodern
reviewed
Mar 7, 2024
zodern
reviewed
Mar 7, 2024
denihs
reviewed
Mar 7, 2024
Grubba27
approved these changes
Mar 11, 2024
denihs
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS-352
Context: #13054 (comment)
Reproduction
Describe the next methods in the server.
Run on the client:
Check how the test is described on the PR. A failing scenario that reproduce the issue is depicted in the next picture. Warning logs
Method took too long
also showed up.Fix
The fix relied on ensure the client queue triggers next method after the stub(simulation) finished for the previous one. This also fixed the logs.