[Meteor 3] Added waitUntilAllLoaded safety check.
#13102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
denihs
previously approved these changes
Apr 23, 2024
✅ Deploy Preview for v3-migration-docs canceled.
|
nachocodoner
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Could we also add the suggestion here to avoid meteor reset on upgrade?
#13104 (comment)
denihs
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended in #13095 (comment), I added additional check in
waitUntilAllLoadedin case it gets called while the last module is still being loaded. I was not able to prepare a test for that (the queue is never empty in my tests), I didn't add any.