Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meteor 3] Environment Variable Tweaks #13128
[Meteor 3] Environment Variable Tweaks #13128
Changes from all commits
5acf2c5
c6df7cb
3c82f87
85c4c68
b544f3c
08c2d7b
ce37839
d2d7386
6822f65
e6eb9ed
e783309
58a1fcb
0116eb2
75221de
a8edea4
e7d8d32
462b48e
52712ee
706a4af
aedb02c
92b550f
b7ab641
d27946d
67c3850
525df1a
307029b
3696e85
3b77370
1e3a2b0
e413a04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will not work.
We need to wait for the
func()
to finish and reset the states ofCURRENT_VALUE_KEY_NAME
andUPPER_CALL_DYNAMICS_KEY_NAME
after thefunc()
is done.This is because you can call a
withValues
inside another, and you need to set and reset those states to keep context between calls.Otherwise, you'll get issues like this: #13063
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13063 changed it to create a new dynamics object each time instead of mutating the parent dynamics. This should remove the need to reset the state since the parent and children all have their own state. If you comment out the reset code, the example code from the PR description stills works correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @zodern, I will include that code as a test just to make sure.