Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oauth_.fetch invocation on github_server and google_server #13153

Merged
merged 5 commits into from
May 23, 2024

Conversation

brunoeduardodev
Copy link

Description

This PR fixes the invocation of the OAuth._fetch() method on the github_server and google_server of their oauth.
This fix is explained in more details on the Additional Notes of the Issue #13152.

I've set the base of the Pull Request as release-3.0 since the devel branch seems to not be fully updated with the code on release-3.0 (on the devel branch, this implementation was still using Fetch API and findOne invocations.)

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for v3-migration-docs canceled.

Name Link
🔨 Latest commit 2c2dd3a
🔍 Latest deploy log https://app.netlify.com/sites/v3-migration-docs/deploys/664f586f4fdf700008062773

Copy link

netlify bot commented May 21, 2024

Deploy Preview for v3-meteor-api-docs canceled.

Name Link
🔨 Latest commit 2c2dd3a
🔍 Latest deploy log https://app.netlify.com/sites/v3-meteor-api-docs/deploys/664f586ffb7b550008a5fac4

Copy link
Member

@nachocodoner nachocodoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

I adapted all account packages in my PR #13127. During this process, I provided tests with mocks, since these packages had side effects involving external cloud services that can't be tested easily. To do this, I used the standard OAuth._fetch, as in other packages. However, I missed an interface difference in the process.

I will pay more attention to interfaces in Meteor codebase, which lacks clear type-checking, above all on refactors on packages without coverage. And of course, more manual testing even when many scenarios affected. Regarding tests on this regression, I can't think of a way to properly verify behavior other than parameter checking, but I don't think it's necessary.

@denihs denihs merged commit bae5597 into meteor:release-3.0 May 23, 2024
9 of 10 checks passed
@denihs
Copy link
Contributor

denihs commented May 23, 2024

Hey @brunoeduardodev, I've just bumped the version for those packages, so you don't need to wait until the release:

google-oauth@1.4.5-rc300.3
github-oauth@1.4.2-rc300.3

@brunoeduardodev
Copy link
Author

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meteor: 3.0.0-rc1] - github-oauth Using findOne instead of findOneAsync
5 participants