-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: oauth_.fetch invocation on github_server and google_server #13153
Conversation
✅ Deploy Preview for v3-migration-docs canceled.
|
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
I adapted all account packages in my PR #13127. During this process, I provided tests with mocks, since these packages had side effects involving external cloud services that can't be tested easily. To do this, I used the standard OAuth._fetch
, as in other packages. However, I missed an interface difference in the process.
I will pay more attention to interfaces in Meteor codebase, which lacks clear type-checking, above all on refactors on packages without coverage. And of course, more manual testing even when many scenarios affected. Regarding tests on this regression, I can't think of a way to properly verify behavior other than parameter checking, but I don't think it's necessary.
Hey @brunoeduardodev, I've just bumped the version for those packages, so you don't need to wait until the release: google-oauth@1.4.5-rc300.3 |
thanks!! |
Description
This PR fixes the invocation of the OAuth._fetch() method on the
github_server
andgoogle_server
of their oauth.This fix is explained in more details on the Additional Notes of the Issue #13152.
I've set the base of the Pull Request as
release-3.0
since thedevel
branch seems to not be fully updated with the code onrelease-3.0
(on thedevel
branch, this implementation was still using Fetch API andfindOne
invocations.)