Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give environmental variables precedence when sending emails over the galaxy config #1647

Closed
wants to merge 1 commit into from

Conversation

Tarang
Copy link
Contributor

@Tarang Tarang commented Dec 2, 2013

The commit 6db8180 broke the ability to set a custom SMTP server with meteor deploy hosting and presumably galaxy hosted apps too:

The section of the docs goes

For apps deployed with meteor deploy, MAIL_URL defaults to an account (provided by Mailgun) which allows apps to send up to 200 emails per day; you may override this default by assigning to process.env.MAIL_URL before your first call to Email.send.

So here the precedence is just re-ordered and environmental variables take precedence over a galaxy configuration.

@glasser
Copy link
Contributor

glasser commented Dec 3, 2013

Thanks for this. I have a different approach that @sixolet is going to review today.

@glasser glasser closed this Dec 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants