Template subs connection #4099
Merged
Template subs connection #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified Blaze.TemplateInstance.prototype.subscribe and Blaze.View.prototype.subscribe
|
@Slava take a look? |
Closed
|
Are there tests for this change? |
|
@Slava I modified one of the tests to kind of test this option. |
| "templateSub", futureId, subscribeCallback); | ||
| var subHandle2 = this.subscribe("templateSub", futureId, { | ||
| onReady: subscribeCallback, | ||
| connection: Meteor.connection |
There was a problem hiding this comment.
@stubailo I am sure this test does not cover a situation where the connection is different from the standard one.
martijnwalraven
pushed a commit
that referenced
this pull request
Feb 22, 2016
Template subs connection
martijnwalraven
pushed a commit
that referenced
this pull request
Feb 22, 2016
Template subs connection
This was referenced May 17, 2021
filipenevola
pushed a commit
that referenced
this pull request
Oct 19, 2021
Template subs connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
connectionoptions totemplate.subscribe, based on @jamgold's pull request.