Return all google profile data for the user #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks @jperl! @avital and I talked about this and as discussed at #636, we think it'd be better to whitelist the fields. It would definitely be good to add the additional fields from Google though. Could you submit a pull request that specifically copies over the fields from Google that you think would be useful? There's another question here, which is how these fields are synchronized/updated from Google after initial account creation. If you think that saving the values at account creation time is a good starting point, though, happy to let that slide for now (since people are already doing this manually.) |
StorytellerCZ
pushed a commit
that referenced
this pull request
Sep 18, 2021
StorytellerCZ
pushed a commit
that referenced
this pull request
Oct 1, 2021
Add comment about having to manually copy the Android APK when using Crosswalk during Android build process. See #5274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful inside In Accounts.onCreateUser to get the picture, if the email is verified, etc..
https://developers.google.com/accounts/docs/OAuth2Login#userinfocall