jquery dependency fix for check package #6710
Conversation
|
I just want to reiterate this is a work in progress and needs to be tested. |
| @@ -3,6 +3,9 @@ | |||
| // Things we explicitly do NOT support: | |||
| // - heterogenous arrays | |||
|
|
|||
| //XXX: import from main lodash library if Meteor updates to use lodash instead of underscore | |||
| const isPlainObject = Npm.require('lodash.isplainobject'); | |||
There was a problem hiding this comment.
This works also on client? This is new in 1.3? Interesting.
There was a problem hiding this comment.
I think you are right that it does not work on client.
Can we just use require now with 1.3? It looks like modules, ecmascript and babel packages are in core build now.
Like I said, have not tested and just trying to make some progress.
| @@ -4,15 +4,17 @@ Package.describe({ | |||
| }); | |||
|
|
|||
| Package.onUse(function (api) { | |||
| api.use(['underscore', 'ejson'], ['client', 'server']); | |||
| api.use('jquery', 'client'); | |||
| api.use(['underscore', 'modules', 'ejson'], ['client', 'server']); | |||
There was a problem hiding this comment.
I think you want to actually depend on ecmascript instead of modules here, especially if you are using const in the code.
There was a problem hiding this comment.
I tried that, but got an error with a circular reference that ecmascript package depended on check. I'll just change const to var.
|
Closing as solution implemented as shim function. |
This is is meant to fix the jquery dependency in the check package for the isPlainObject function by using a version of isPlainObject from lodash, issue #6563
I was not able to get tests to run in my environment and this should be checked by someone with more experience on Meteor core. I hope this can at least help get this fix implemented soon.