Reconnect to mongo indefinitely. #7880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for #7822 It seems the driver now always autoReconnects, but only for 30s. To get the old (sensible) behavior of endlessly reconnecting, we set `reconnectTries` to 0.
|
If we do a point release, I should rename this branch to If not, we should cherry-pick this commit to |
tmeasday
force-pushed
the
7822-mongo-reconnect-settings
branch
from
3dc9fa5
to
ce2c284
Compare
|
Published (Due to vagaries in version ordering, you'll need to put |
benjamn
approved these changes
Oct 7, 2016
|
Can you add a note about this to |
|
Is this in a released |
|
Yes, I've published it as |
benjamn
added a commit
that referenced
this pull request
Oct 8, 2016
Setting mongoOptions.server.auto_reconnect was removed by #7880 via commit 0ffb9ac, though it seems the Server options still respect autoReconnect, even in version 2.2 of the driver: http://mongodb.github.io/node-mongodb-native/2.2/api/Server.html That said, having inspected the code of the `mongodb` package, I do not believe this change is really critical, since the default value for autoReconnect appears to be true. More importantly, I can't find any support in the code of the `mongodb` npm package or its dependencies for the claim that setting mongoOptions.server.reconnectTries to 0 is the same as making it infinite, so this commit sets it to Infinity.
benjamn
pushed a commit
that referenced
this pull request
Oct 21, 2016
* Reconnect to mongo indefinitely. A fix for #7822 It seems the driver now always autoReconnects, but only for 30s. To get the old (sensible) behavior of endlessly reconnecting, we set `reconnectTries` to 0. * Releasing an rc of mongo package
benjamn
added a commit
that referenced
this pull request
Oct 21, 2016
Setting mongoOptions.server.auto_reconnect was removed by #7880 via commit 0ffb9ac, though it seems the Server options still respect autoReconnect, even in version 2.2 of the driver: http://mongodb.github.io/node-mongodb-native/2.2/api/Server.html That said, having inspected the code of the `mongodb` package, I do not believe this change is really critical, since the default value for autoReconnect appears to be true. More importantly, I can't find any support in the code of the `mongodb` npm package or its dependencies for the claim that setting mongoOptions.server.reconnectTries to 0 is the same as making it infinite, so this commit sets it to Infinity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we want to do a point release for this one, or just release a new version of the
mongopackage and sweep it up in the next release.AFAICT, fixes #7822, and possibly various other mongo-related bugs I've been hearing about.