Throw more meaningful error if .babelrc is not a valid JSON file #9052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimme
reviewed
Sep 4, 2017
| JSON.parse(inputFile.readAndWatchFile(babelrcPath)); | ||
| } catch (e) { | ||
| if (e instanceof SyntaxError) { | ||
| throw new Error(".babelrc is not a valid JSON file: " + e.message); |
There was a problem hiding this comment.
Seems like this gets rid of the stacktrace in e as it's not passed into the new error being thrown.
There was a problem hiding this comment.
Are you sure? The stack trace should be similar because the error is thrown at (almost) the same source location as before.
There was a problem hiding this comment.
I'm thinking it's loosing the stack trace from the command that threw the error we're catching.
There was a problem hiding this comment.
What about just
e.message = ".babelrc is not a valid JSON file: " + e.message;
throw e;
klaussner
force-pushed
the
babelrc-error-message
branch
from
0dace5f
to
cae4eb0
Compare
zimme
approved these changes
Sep 6, 2017
benjamn
approved these changes
Sep 7, 2017
GulajavaMinistudio
added a commit
to GulajavaMinistudio/meteor
that referenced
this pull request
Sep 8, 2017
Throw more meaningful error if .babelrc is not a valid JSON file (meteor#9052)
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small improvement of the error that is thrown if a
.babelrcfile doesn't contain valid JSON. For example, the error message will beinstead of
for the invalid
.babelrcfileResolves #8792