Statically import SockJS in both modern and legacy bundles. #9985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not including SockJS in the modern JS bundle was a nice bundle size savings (28KB before gzip), but SockJS works better than a native WebSocket for clients that are stuck in unusual networking situations, and the fallback of using dynamic import() to load SockJS when the native WebSocket failed was much slower than simply including SockJS in the bundle and using it from the start. Moreover, the new `meteor create --minimal` starter app does not use socket-stream-client (nor DDP), so going back to including SockJS in both the modern and the legacy bundles should have no impact on the minimal modern bundle size. If you want to continue using a native WebSocket instead of SockJS, you can always pin the older version of the socket-stream-client package: meteor add socket-stream-client@0.2.1
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not including
SockJSin the modern JS bundle was a nice bundle size savings (28KB before gzip), butSockJSworks better than a nativeWebSocketfor clients that are stuck in unusual networking situations, and the fallback of using dynamicimport()to loadSockJSwhen the nativeWebSocketfailed was much slower than simply includingSockJSin the bundle and using it from the start.Moreover, the new
meteor create --minimalstarter app does not usesocket-stream-client(nor DDP), so going back to includingSockJSin both the modern and the legacy bundles should have no impact on the minimal modern bundle size.If you want to continue using a native
WebSocketinstead ofSockJS, you can always pin the older version of the socket-stream-client package:Once this change is published, the workaround I suggested to @p3pp8 here will no longer be necessary: #9917 (comment)