Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Dependency issues: Importing Nightmare (for the new dispatch:mocha) fails #219

Closed
wants to merge 3 commits into from
Closed

Conversation

0o-de-lally
Copy link

@0o-de-lally 0o-de-lally commented Feb 17, 2017

@aldeed 's new dispatch:mocha works great on newly-created blank apps. But after installing on Meteor Todos app as a reference, some issues come up.

Server tests work fine, as expected. But client tests with Nightmare seem to hang. It's failing silently with no errors in 'debug'.

Interestingly, if you try to use Nightmare in the Todo app server side you get Error: Cannot find module './actions' This does not happen on a newly created app, which runs fine.

Updating packages or meteor does not help.

This pull request only adds the npm script 'new-mocha', and also a reproduction file ./server/reproduction.nightmare.js for discussion.

Meteor-Community-Packages/meteor-mocha#11

@apollo-cla
Copy link

@keyscores: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@0o-de-lally
Copy link
Author

@hwillson I think you were the last person to look at the phantomjs issues. Nightmare seems to work great except for this dependency issue.

@aldeed
Copy link
Contributor

aldeed commented Feb 19, 2017

@keyscores I got all of the new dispatch:mocha browsers to work in the Todos app on my machine. One thing to try is add DEBUG=nightmare:*,electron:* before npm test or whatever test command, and then you'll see the nightmare and electron logs. The only issue I ran into sometimes was the "too many open files" issue, which is a known issue with current Meteor. You can get around that by setting your ulimit high and also meteor reset before each time running the tests.

@hwillson
Copy link
Contributor

Thanks for reporting this @lpgeiger - #256 fixes this.

@hwillson hwillson closed this Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants