Cursor methods #36
Merged
Cursor methods #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `events` format for `info` Ignore observe events created by blaze (by checking return value) Fix bugs: setInfo called outside the callback
- add hijacks for global helpers - clean up hijack.js file - remove unnecessary result checks for Cusrsors (from iron router hooks) - fix bug: results of original function wasn't returned by hijacked function
Events no longer holds any zone events setTimeout, method calls, etc. Events are only used for small events such as Session.set
| && !notFromForEach | ||
| && typeof callback === 'function') { | ||
| args[0] = function () { | ||
| var args = Array.prototype.slice.call(arguments); |
There was a problem hiding this comment.
First one was args for fetch, forEach, map (callback, thisArg) and the second one is for the callback (document, index, cursor).
There was a problem hiding this comment.
ah okay. I didn't see that. sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #34