Make thread_count an AsyncPublisher constructor argument #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
Added a commit to make |
methylDragon
approved these changes
Dec 29, 2022
methylDragon
pushed a commit
that referenced
this pull request
Dec 30, 2022
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this more closely aligns with what the ROS 1 code is doing. I think sensor models and motion models will need similar changes. I don't see any linker errors or test failures (except linters) with these changes.
In ROS 1
AsyncPublisherhas an explicit constructor that allows specifying the number of threadsAsyncPublisherchoose how many threads they need