Skip to content
This repository has been archived by the owner on Apr 28, 2023. It is now read-only.

Added youtube snippet scss to marble #146

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Conversation

JosephCurley
Copy link
Contributor

No description provided.

Copy link
Collaborator

@stephenhmarsh stephenhmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but is it possible to address the accessibility check?

Screen Shot 2021-10-19 at 1 50 39 PM

Copy link
Collaborator

@davidseguin davidseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but we might use these other places than the rte, no? I made one of these for Perspectives in Rodan, that is showing a YT video via the API. It seems like it would be more useful to have than just an rte-snippet

@JosephCurley
Copy link
Contributor Author

Looks great but is it possible to address the accessibility check?

Screen Shot 2021-10-19 at 1 50 39 PM

Great note! Fixed it.

@JosephCurley
Copy link
Contributor Author

Great, but we might use these other places than the rte, no? I made one of these for Perspectives in Rodan, that is showing a YT video via the API. It seems like it would be more useful to have than just an rte-snippet

Yeah for sure, I just want to get a file that can be pulled into any project that has all the snippet SCSS. It doesnt necessarily mean we cant use this somewhere else, maybe making this into a mixin is a good future move

@JosephCurley JosephCurley merged commit ec05595 into main Oct 22, 2021
@JosephCurley JosephCurley deleted the rte-snippet-youtube branch October 22, 2021 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants