Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff up pyaerocom #1119

Open
lewisblake opened this issue Apr 14, 2024 · 0 comments · May be fixed by #1129
Open

Ruff up pyaerocom #1119

lewisblake opened this issue Apr 14, 2024 · 0 comments · May be fixed by #1129
Labels
enhancement New feature or request style
Milestone

Comments

@lewisblake
Copy link
Member

Is your feature request related to a problem? Please describe.
@avaldebe has shown us the many benefits of using ruff as a linter / formatter. We should move to use ruff instead of black and isort.

Describe the solution you would like to see
A clear and concise description of what you want to happen.

  • A PR applying ruff to the pyaerocom code base.
  • Changes in the dependencies to drop isort and black and add ruff.
  • Changes in the pre-commit hooks to just use ruff.
  • The commit of the major changes to the code should be added to the .gitignore

Additional context
This should happen rather soon after any large outstanding PRs are merged. #962 should be merged into main-dev before a PR for this is drafted.

@lewisblake lewisblake added enhancement New feature or request style labels Apr 14, 2024
@lewisblake lewisblake added this to the m2024-05 milestone Apr 14, 2024
@heikoklein heikoklein modified the milestones: m2024-05, m2024-08, m2024-09 Apr 16, 2024
@avaldebe avaldebe linked a pull request Apr 19, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request style
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants