Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update testdata creation scripts to current coding style and make sure they still work #604

Closed
jgriesfeller opened this issue Mar 23, 2022 · 3 comments · May be fixed by #691
Closed

update testdata creation scripts to current coding style and make sure they still work #604

jgriesfeller opened this issue Mar 23, 2022 · 3 comments · May be fixed by #691
Assignees
Labels
Milestone

Comments

@jgriesfeller
Copy link
Member

I just added some testdata creation scripts I found in a gitlab repo hwn I needed to update the EBAS testing data.
I think these should be maintained with the code but probabl;y not include in the source distribution.
In any case they use outdated code and except for the EBAS script might not even work anymore.

Someone should look over them and make sure they work and use a decent code style.

@jgriesfeller jgriesfeller self-assigned this Mar 23, 2022
@jgriesfeller jgriesfeller changed the title go through testdata creation scripts update testdata creation scriptsto current coding style and make sure they still work Mar 24, 2022
@jgriesfeller jgriesfeller changed the title update testdata creation scriptsto current coding style and make sure they still work update testdata creation scripts to current coding style and make sure they still work Mar 24, 2022
@avaldebe avaldebe added this to the v0.13.0 milestone Mar 28, 2022
@avaldebe avaldebe modified the milestones: v0.13.0, v0.13.1 Apr 25, 2022
@avaldebe avaldebe self-assigned this Jul 4, 2022
@avaldebe
Copy link
Collaborator

avaldebe commented Jul 4, 2022

I'll create a PR that moves ./pyaerocom/scripts/testdata-minimal/ to ./scripts or ./tests/scripts and imports TESTDATA_ROOT from tests.fixtures.data_access.

Copy link

This issue is stale because it has been open for 365 days with no activity. This issue will be closed in 14 days if no action is taken.

@github-actions github-actions bot added the stale label Jan 14, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants