Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default logs to default directory and cleanup of old logs #1015

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

heikoklein
Copy link
Member

@heikoklein heikoklein commented Feb 28, 2024

  • moving default pyaerocom.log.$PID to logs directory
  • deletion of old log-files after 7 days in logs
  • warning about old logfile pyaerocom.log if it still exists
  • avoid progress-bar when non-interactive

closes #1010

@heikoklein heikoklein added this to the m2024-03 milestone Feb 28, 2024
@heikoklein heikoklein self-assigned this Feb 28, 2024
@heikoklein heikoklein marked this pull request as ready for review February 28, 2024 18:05
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.84%. Comparing base (7ea3b80) to head (5c02cf4).

Files Patch % Lines
pyaerocom/_logging.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1015      +/-   ##
============================================
- Coverage     79.84%   79.84%   -0.01%     
============================================
  Files           108      108              
  Lines         18831    18845      +14     
============================================
+ Hits          15035    15046      +11     
- Misses         3796     3799       +3     
Flag Coverage Δ
unittests 79.84% <84.21%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein heikoklein merged commit 8c7a57f into main-dev Feb 29, 2024
21 checks passed
@heikoklein heikoklein deleted the logging2 branch February 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More logging improvements
2 participants