Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller logging improvements #1018

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Smaller logging improvements #1018

merged 6 commits into from
Mar 1, 2024

Conversation

heikoklein
Copy link
Member

This PR converts print-statements to logger-statements and addresses #1016 .
It also makes logging of metadatastandards-deviations rather a info than a warnings. The aerocom had 3 metadatastandards while pyaerocom tests for a 4th and newer metadatastandard which isn't really needed yet.

closes #1016

@heikoklein heikoklein self-assigned this Mar 1, 2024
@heikoklein heikoklein added this to the m2024-03 milestone Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.84%. Comparing base (8c7a57f) to head (5bbece4).

❗ Current head 5bbece4 differs from pull request most recent head 7792ed3. Consider uploading reports for the commit 7792ed3 to get more accurate results

Files Patch % Lines
pyaerocom/_logging.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1018   +/-   ##
=========================================
  Coverage     79.84%   79.84%           
=========================================
  Files           108      108           
  Lines         18845    18845           
=========================================
+ Hits          15046    15047    +1     
+ Misses         3799     3798    -1     
Flag Coverage Δ
unittests 79.84% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulte dulte mentioned this pull request Mar 1, 2024
pyaerocom/io/readungridded.py Show resolved Hide resolved
@heikoklein heikoklein requested a review from dulte March 1, 2024 11:40
@heikoklein heikoklein merged commit 27327c0 into main-dev Mar 1, 2024
19 checks passed
@heikoklein heikoklein deleted the logging3 branch March 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove print-statments from recent PR and use logging instead
2 participants