Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages argument to WebDisplayOpts class #1025

Merged
merged 4 commits into from
May 28, 2024
Merged

Add pages argument to WebDisplayOpts class #1025

merged 4 commits into from
May 28, 2024

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Mar 7, 2024

Closes #965. Based on the requirements presented there, a default it set to ["maps", "evaluation", "intercomp", "overall", "infos"]. If this default is overridden by providing a pages argument, all the pages which are intended to show up on the web must be provided.

@lewisblake lewisblake added this to the m2024-04 milestone Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.82%. Comparing base (0c8316f) to head (6189c5b).
Report is 1 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/aeroval/experiment_processor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1025   +/-   ##
=========================================
  Coverage     78.82%   78.82%           
=========================================
  Files           128      128           
  Lines         20209    20209           
=========================================
  Hits          15930    15930           
  Misses         4279     4279           
Flag Coverage Δ
unittests 78.82% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake marked this pull request as ready for review March 7, 2024 14:49
@AugustinMortier
Copy link
Member

Looks good. I juste have to implement the logic on the frontend. From which pyaerocom version should I expect this new format?

Also, one current user of this feature is CAMS2_2 that adds reports page. So, it should be explained, to people running those experiments, how they need to modify their config files.

@lewisblake
Copy link
Member Author

Looks good. I juste have to implement the logic on the frontend. From which pyaerocom version should I expect this new format?

Great. >v0.16.0 should have this feature implemented.

Also, one current user of this feature is CAMS2_2 that adds reports page. So, it should be explained, to people running those experiments, how they need to modify their config files.

I will speak to @andagit about how to modify her config files.

Can you approve this, @AugustinMortier if you are okay with it? Thanks.

@lewisblake
Copy link
Member Author

@AugustinMortier will the website be able to handle this before the next release (Tuesday 9.4.24)? Some attention now needs to be given to this PR since there are conflicts

@AugustinMortier
Copy link
Member

AugustinMortier commented Apr 7, 2024 via email

@lewisblake lewisblake modified the milestones: m2024-04, m2024-05 Apr 8, 2024
@lewisblake
Copy link
Member Author

@AugustinMortier Any updates on this?

@AugustinMortier
Copy link
Member

Not yet, sorry. Busy with other projects and initiating the API documentation. I'll try to have a look next week!

@lewisblake lewisblake modified the milestones: m2024-05, m2024-06 May 8, 2024
@AugustinMortier
Copy link
Member

The front end now supports the pages option.
Working example here

@AugustinMortier
Copy link
Member

It would probably make sense to "connect" a little the list of pages in the config file to the actual pyaerocom computation: e.g, if the contour plots have not been processed, but the 'maps' page is in the list of visible pages, the user should have at least a warning (so we avoid ending up with empty pages)..?

@lewisblake lewisblake merged commit 214a4fa into main-dev May 28, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the pages965 branch May 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better configurability of the aeroval pages
2 participants