Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support iris > 3.7 #1061

Merged
merged 12 commits into from
Apr 2, 2024
Merged

support iris > 3.7 #1061

merged 12 commits into from
Apr 2, 2024

Conversation

jgriesfeller
Copy link
Member

No description provided.

@jgriesfeller jgriesfeller linked an issue Mar 18, 2024 that may be closed by this pull request
@jgriesfeller
Copy link
Member Author

It looks like iris does not allow non CF compliant units anymore (since V3.7) I opened a discussion at the iris gihub site: SciTools/iris#5856

Let's see what they say.

@jgriesfeller
Copy link
Member Author

looking at the saver code here:
https://github.com/SciTools/iris/blob/cbb08457fc139249ed89b1970eb326144a7074ec/lib/iris/fileformats/netcdf/saver.py#L1713-L1715
It really seems that we lost the abiliy to save netcdf files with cutom units
The loader part here:
https://github.com/SciTools/iris/blob/cbb08457fc139249ed89b1970eb326144a7074ec/lib/iris/fileformats/_nc_load_rules/helpers.py#L895-L920
does not look promising reagarding loading netcdf files with non CF units either.

@jgriesfeller
Copy link
Member Author

Bad news from iris: One of the maintainers there said that he is surprised that using non CF units ever worked... Digging a bit deeper to see what really changed...

@jgriesfeller
Copy link
Member Author

Things were not as bad as it seemed. As long as the cf_units package understands the the unit, we are still fine. Iris had just changed it's warnings if that was not the case.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (5ff89df) to head (2e4ce15).

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1061   +/-   ##
=========================================
  Coverage     79.27%   79.27%           
=========================================
  Files           109      109           
  Lines         19023    19023           
=========================================
  Hits          15080    15080           
  Misses         3943     3943           
Flag Coverage Δ
unittests 79.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller changed the title 1st try for latest iris and no pinning of xarray support iris > 3.7 Apr 2, 2024
@jgriesfeller jgriesfeller marked this pull request as ready for review April 2, 2024 09:06
@lewisblake lewisblake merged commit b201489 into main-dev Apr 2, 2024
8 checks passed
@lewisblake lewisblake deleted the 1019-support-latest-iris-38 branch April 2, 2024 10:46
@heikoklein heikoklein added this to the m2024-04 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support latest Iris 3.8
3 participants