-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test with oldest dependencies to CI #1154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1154 +/- ##
=========================================
Coverage 78.69% 78.69%
=========================================
Files 127 127
Lines 20090 20090
=========================================
Hits 15810 15810
Misses 4280 4280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please don't increase the number of CI-tests, max 4. I'd rather like the 3.10 test to be the 'old version' test, including the old dependencies. |
- name: Setup environment | ||
run: | | ||
pip install --upgrade pip | ||
pip install pdm | ||
pdm lock --strategy direct_minimal_versions -v | ||
pdm install -v | ||
pip install pytest | ||
pip freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this logic be moved to the tox environment for python 3.10?
that way the same test can be run locally and there is no need to change the jobs on CI
Change Summary
Related issue number
fix #1153
Checklist