Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with oldest dependencies to CI #1154

Closed
wants to merge 17 commits into from

Conversation

thorbjoernl
Copy link
Collaborator

Change Summary

Related issue number

fix #1153

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the enhancement New feature or request label May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (6d4aea3) to head (3b3407e).
Report is 6 commits behind head on main-dev.

❗ Current head 3b3407e differs from pull request most recent head baa2b57. Consider uploading reports for the commit baa2b57 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1154   +/-   ##
=========================================
  Coverage     78.69%   78.69%           
=========================================
  Files           127      127           
  Lines         20090    20090           
=========================================
  Hits          15810    15810           
  Misses         4280     4280           
Flag Coverage Δ
unittests 78.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heikoklein
Copy link
Member

Please don't increase the number of CI-tests, max 4. I'd rather like the 3.10 test to be the 'old version' test, including the old dependencies.

Comment on lines +123 to +130
- name: Setup environment
run: |
pip install --upgrade pip
pip install pdm
pdm lock --strategy direct_minimal_versions -v
pdm install -v
pip install pytest
pip freeze
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this logic be moved to the tox environment for python 3.10?
that way the same test can be run locally and there is no need to change the jobs on CI

@heikoklein heikoklein added this to the m2024-06 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI-tests with minimum versions of main libraries
3 participants