Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that perform real mos evaluations #1172

Merged
merged 23 commits into from
May 31, 2024
Merged

Add tests that perform real mos evaluations #1172

merged 23 commits into from
May 31, 2024

Conversation

charlienegri
Copy link
Collaborator

@charlienegri charlienegri commented May 20, 2024

Change Summary

tests with minimal data: 3 stations, 1 component

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (f4697fc) to head (1a67c46).
Report is 10 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1172      +/-   ##
============================================
+ Coverage     78.79%   79.37%   +0.57%     
============================================
  Files           128      128              
  Lines         20164    20158       -6     
============================================
+ Hits          15889    16001     +112     
+ Misses         4275     4157     -118     
Flag Coverage Δ
unittests 79.37% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charlienegri
Copy link
Collaborator Author

charlienegri commented May 21, 2024

splitting the cams2_83 tests works, but I am not sure we want this as a permanent solution...

@charlienegri charlienegri marked this pull request as ready for review May 21, 2024 15:49
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the tests can use another iteration

tests/cams2_83/test_cams2_83_cli_mos.py Outdated Show resolved Hide resolved
tests/cams2_83/test_cams2_83_cli_mos.py Outdated Show resolved Hide resolved
tests/cams2_83/test_cams2_83_cli_mos.py Outdated Show resolved Hide resolved
tests/cams2_83/test_cams2_83_cli_mos.py Outdated Show resolved Hide resolved
@charlienegri
Copy link
Collaborator Author

thanks for the suggestions, better indeed

@charlienegri
Copy link
Collaborator Author

this is now ready to be shipped

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor clean up, then can merge

tests/cams2_83/test_cams2_83_cli.py Outdated Show resolved Hide resolved
@heikoklein heikoklein added this to the m2024-06 milestone May 28, 2024
@charlienegri charlienegri merged commit b9c3b6c into main-dev May 31, 2024
8 checks passed
@lewisblake lewisblake deleted the mos_tests branch June 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants