First try at fixing col setup without start stop. Model validator for…

pyaerocom/colocation/colocation_setup.py

@@ -463,6 +463,36 @@ def validate_no_forbidden_keys(self):
         for key in self.FORBIDDEN_KEYS:
             if key in self.model_fields:
                 raise ValidationError
+        return self
+
+    @model_validator(mode="after")
+    # @classmethod
+    def validate_start_stop_xand(self):
+        if not (self.start and self.stop):
+            if self.start or self.stop:
+                raise ValueError("Both start and stop need to be provided or both not provided.")
+        return self
+
+    # @model_validator(mode="after")
+    # @classmethod
+    # def validate_obs_config(cls, v: PyaroConfig):
+    #     if v is not None and cls.obs.config.name != cls.obs_id:
+    #         logger.info(
+    #             f"Data ID in Pyaro config {v.name} does not match obs_id {cls.obs_id}. Setting Pyaro config to None!"
+    #         )
+    #         v = None
+    #     if v is not None:
+    #         if isinstance(v, dict):
+    #             logger.info("Obs config was given as dict. Will try to convert to PyaroConfig")
+    #             v = PyaroConfig(**v)
+    #         if v.name != cls.obs_id:
+    #             logger.info(
+    #                 f"Data ID in Pyaro config {v.name} does not match obs_id {cls.obs_id}. Setting Obs ID to match Pyaro Config!"
+    #             )
+    #             cls.obs_id = v.name
+    #         if cls.obs_id is None:
+    #             cls.obs_id = v.name
+    #     return v
 
     @cached_property
     def basedir_logfiles(self):
@@ -471,27 +501,6 @@ def basedir_logfiles(self):
             p.mkdir(parents=True, exist_ok=True)
         return str(p)
 
-    @model_validator(mode="after")
-    @classmethod
-    def validate_obs_config(cls, v: PyaroConfig):
-        if v is not None and cls.obs.config.name != cls.obs_id:
-            logger.info(
-                f"Data ID in Pyaro config {v.name} does not match obs_id {cls.obs_id}. Setting Pyaro config to None!"
-            )
-            v = None
-        if v is not None:
-            if isinstance(v, dict):
-                logger.info("Obs config was given as dict. Will try to convert to PyaroConfig")
-                v = PyaroConfig(**v)
-            if v.name != cls.obs_id:
-                logger.info(
-                    f"Data ID in Pyaro config {v.name} does not match obs_id {cls.obs_id}. Setting Obs ID to match Pyaro Config!"
-                )
-                cls.obs_id = v.name
-            if cls.obs_id is None:
-                cls.obs_id = v.name
-        return v
-
     def add_glob_meta(self, **kwargs):
         """
         Add global metadata to :attr:`add_meta`

pyaerocom/colocation/colocator.py

@@ -914,8 +914,13 @@ def _infer_start_stop_yr_from_model_reader(self):
         self.stop = last
 
     def _check_set_start_stop(self):
-        if self.colocation_setup.start is None:
+        if self.colocation_setup.start is None and self.colocation_setup.stop is None:
             self._infer_start_stop_yr_from_model_reader()
+            self.start, self.stop = start_stop(self.start, self.stop)
+        else:
+            self.start, self.stop = start_stop(
+                self.colocation_setup.start, self.colocation_setup.stop
+            )
         if self.colocation_setup.model_use_climatology:
             if self.colocation_setup.stop is not None or not isinstance(
                 self.colocation_setup.start, int
@@ -925,7 +930,6 @@ def _check_set_start_stop(self):
                     'climatology fields, please specify "start" as integer '
                     'denoting the year, and set "stop"=None'
                 )
-        self.start, self.stop = start_stop(self.colocation_setup.start, self.colocation_setup.stop)
 
     def _coldata_savename(self, obs_var, mod_var, ts_type, **kwargs):
         """Get filename of colocated data file for saving"""