Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore default colormaps #957

Merged
merged 2 commits into from
Dec 12, 2023
Merged

restore default colormaps #957

merged 2 commits into from
Dec 12, 2023

Conversation

lewisblake
Copy link
Member

close #953

Copy link
Member

@AugustinMortier AugustinMortier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The absolute numbers for od550dust look a little bit small to me, but I guess it depends on the first projects that were looking at it (which region..). We could adjust it later if needed.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46b2e67) 78.95% compared to head (3528cad) 78.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #957      +/-   ##
============================================
+ Coverage     78.95%   78.97%   +0.02%     
============================================
  Files           105      105              
  Lines         18423    18423              
============================================
+ Hits          14545    14550       +5     
+ Misses         3878     3873       -5     
Flag Coverage Δ
unittests 78.97% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake merged commit 4e4c64f into main-dev Dec 12, 2023
21 checks passed
@lewisblake lewisblake deleted the colormaps953 branch December 12, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore default colormaps
2 participants