-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add close_issues.yml to GitHub workflows to close issues after extended period of inactivity #961
Conversation
@avaldebe current set up will mark stale after 1 year and close 14 days after. This is fairly lenient. I'm curious if you (and others @dulte @jgriesfeller ) think we should decrease this timeframe. Open to other suggestions - please mention here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #961 +/- ##
============================================
- Coverage 78.95% 78.94% -0.01%
============================================
Files 105 105
Lines 18423 18421 -2
============================================
- Hits 14545 14543 -2
Misses 3878 3878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.github/workflows/close_issues.yml
Outdated
days-before-issue-stale: 365 | ||
days-before-issue-close: 14 | ||
stale-issue-label: "stale" | ||
stale-issue-message: "This issue is stale because it has been open for 365 days with no activity." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add to the comment that the issue will close in x days. If it's not explicit, we will forget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This issue is stale because it has been open for 365 days with no activity. This issue will be closed in 14 days if not addressed."
Or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worded slightly differently before I saw this comment but good suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have the stale
label, I hope it will be created the first time. Also, what will happen to issues inactive for more than 365 days? Will they be ignored or declared stale in bulk?
I think that the best is to merge and see what happens.
Close #960