Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close_issues.yml to GitHub workflows to close issues after extended period of inactivity #961

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

lewisblake
Copy link
Member

Close #960

@lewisblake
Copy link
Member Author

@avaldebe current set up will mark stale after 1 year and close 14 days after. This is fairly lenient. I'm curious if you (and others @dulte @jgriesfeller ) think we should decrease this timeframe. Open to other suggestions - please mention here

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9d86a1) 78.95% compared to head (ed30034) 78.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #961      +/-   ##
============================================
- Coverage     78.95%   78.94%   -0.01%     
============================================
  Files           105      105              
  Lines         18423    18421       -2     
============================================
- Hits          14545    14543       -2     
  Misses         3878     3878              
Flag Coverage Δ
unittests 78.94% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

days-before-issue-stale: 365
days-before-issue-close: 14
stale-issue-label: "stale"
stale-issue-message: "This issue is stale because it has been open for 365 days with no activity."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add to the comment that the issue will close in x days. If it's not explicit, we will forget

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This issue is stale because it has been open for 365 days with no activity. This issue will be closed in 14 days if not addressed."

Or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worded slightly differently before I saw this comment but good suggestion.

@lewisblake lewisblake requested a review from dulte January 10, 2024 12:02
@lewisblake lewisblake changed the title Add close_issues.yml Add close_issues.yml to GitHub workflows to close issues after extended period of inactivity Jan 10, 2024
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have the stale label, I hope it will be created the first time. Also, what will happen to issues inactive for more than 365 days? Will they be ignored or declared stale in bulk?
I think that the best is to merge and see what happens.

@lewisblake lewisblake merged commit e0b14ad into main-dev Jan 11, 2024
20 of 21 checks passed
@lewisblake lewisblake deleted the closeissues960 branch January 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add closing inactive issues to GitHub workflows
3 participants