Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New interface reader #976

Merged
merged 51 commits into from
Feb 27, 2024
Merged

New interface reader #976

merged 51 commits into from
Feb 27, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Jan 30, 2024

Pyaro integration

@dulte
Start of pyaro integration
14799e0
@dulte
more pyaro
bd96e55
@dulte
Adds pyaro option to readungridded
3afa88a
@dulte
First conversion between pyaro and ungriddeddata
9311f44
@dulte
Can now colocate
eb77bb7
@dulte
ReadPyaro now gets list of readers and the correct engine from Pyaro
5a2f15b
@dulte
Starts cleaing colocation after changes done in last commit 5a2f15b
87d6ce1
@dulte
Added reading of units. Makes it work with colocation
c53d747
@dulte
pyaro reader now calculates ts_type. raises an error of more than one…
a019ad7 
… is found for a station
@dulte
pyaro is now a MVP for aeroval
d0dc4e5
@dulte
Fix filters for pyaro
726cd0d
@dulte
First MVP for catalogs for pyaro
d54d220
@dulte
Adds saving and loading to pyaroconfig
39e0549
@dulte
Adds default pyaro catalog
ce1bad7
@dulte
Adds tests for pyaro reading and config
2a2565a
@dulte
Adds pyaro to pyprojects
272f17b
@dulte
Adds pydantic to pyproject
116f5e2
@dulte
Adds future annotation import
4b582a5
@dulte
Removes Self typing due to incompatibility with 3.9
1b09939
@dulte
removes version of pydantic due to pip and conda using diff versions
7da4da0
@dulte
Merge main-dev to branch
cbc6d1c
@dulte
Removes merge text
9584516
@dulte
Fixes named parameters of read_dataset
c8051c0
@dulte
Adds use of config to compute post
0e1fc23
@dulte
Some formatting with black
4a77d01
@dulte
Removes unused file
ecb7feb
@dulte
Formatting with isort
97fa167
@dulte
More files formatted with isort
6ab8cc1
@dulte dulte mentioned this pull request Jan 30, 2024
Closed
lewisblake
lewisblake requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Some clean up needed and I have some questions about introducing dependencies and whether you're planning on introducing pickle files into CI. Overall this is really cool to see, and would be great to include. I also see there are some notes-to-self about things to do. Many of those things you've marked as TODO would be great to include in this PR if you think it's possible. Nice work!

pyaerocom/colocation_auto.py Outdated Show resolved Hide resolved
pyaerocom/colocation_auto.py Outdated Show resolved Hide resolved
pyaerocom/colocation_auto.py Outdated Show resolved Hide resolved
pyaerocom/io/pyaro/pyaro_config.py Outdated Show resolved Hide resolved
pyaerocom/io/pyaro/read_pyaro.py Outdated Show resolved Hide resolved
pyaerocom/io/readungridded.py Outdated Show resolved Hide resolved
pyproject.toml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth talking about introducing a dependency. It seems like a solid one and a good choice though.

tests/io/pyaro/test_read_pyaro.py Outdated Show resolved Hide resolved
tests/io/test_cachehandler_ungridded.py Outdated Show resolved Hide resolved
tests/io/test_cachehandler_ungridded.py Outdated Show resolved Hide resolved
heikoklein
heikoklein requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fail, reverting approve

@heikoklein heikoklein added this to the m2024-03 milestone Feb 27, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.60399% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 79.84%. Comparing base (553f8e9) to head (46355a5).

Files Patch % Lines
pyaerocom/io/readungridded.py 69.62% 24 Missing ⚠️
pyaerocom/io/pyaro/read_pyaro.py 90.80% 16 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           main-dev     #976      +/-   ##
============================================
+ Coverage     78.97%   79.84%   +0.86%     
============================================
  Files           106      108       +2     
  Lines         18489    18831     +342     
============================================
+ Hits          14602    15035     +433     
+ Misses         3887     3796      -91
Flag Coverage Δ
unittests 79.84% <88.60%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lewisblake
lewisblake approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🦄 🌟

@dulte dulte merged commit 7ea3b80 into main-dev Feb 27, 2024
21 checks passed
@heikoklein heikoklein mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heikoklein heikoklein heikoklein approved these changes

@lewisblake lewisblake lewisblake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
m2024-03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dulte @heikoklein @lewisblake