Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up ICOS reader and tests to work with CO2, CH3, and CO #979

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix up ICOS reader and tests to work with CO2, CH3, and CO #979

merged 2 commits into from
Feb 5, 2024

Conversation

lewisblake
Copy link
Member

Close #975

@lewisblake lewisblake self-assigned this Feb 1, 2024
@lewisblake lewisblake added this to the m2024-02 milestone Feb 1, 2024
@lewisblake
Copy link
Member Author

Screenshot from 2024-02-01 11-42-02
ICOS tests pass locally

@jgriesfeller
Copy link
Member

I also pulled this into PR #978. The tests work.

@lewisblake lewisblake marked this pull request as ready for review February 5, 2024 08:39
@lewisblake lewisblake merged commit 2785166 into main-dev Feb 5, 2024
7 of 19 checks passed
@lewisblake lewisblake deleted the icosco2 branch February 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaldebe avaldebe Awaiting requested review from avaldebe

Assignees

@lewisblake lewisblake

Labels
testing
Projects
None yet
Milestone
m2024-02
Development

Successfully merging this pull request may close these issues.

ICOS tests are broken
3 participants
@lewisblake @jgriesfeller @avaldebe