Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run AeroVal experiment from CLI #998

Merged
merged 3 commits into from
Feb 26, 2024
Merged

run AeroVal experiment from CLI #998

merged 3 commits into from
Feb 26, 2024

Conversation

avaldebe
Copy link
Collaborator

No description provided.

@avaldebe avaldebe added enhancement New feature or request user-friendliness Updates that improve ease of use labels Feb 16, 2024
@avaldebe avaldebe added this to the m2024-03 milestone Feb 16, 2024
@avaldebe avaldebe self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.96%. Comparing base (8d067d3) to head (c2de306).

Files Patch % Lines
pyaerocom/scripts/cli.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev     #998   +/-   ##
=========================================
  Coverage     78.95%   78.96%           
=========================================
  Files           105      105           
  Lines         18478    18500   +22     
=========================================
+ Hits          14590    14609   +19     
- Misses         3888     3891    +3     
Flag Coverage Δ
unittests 78.96% <86.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests for the CLI. What do you think about adding a test for this?

@avaldebe
Copy link
Collaborator Author

avaldebe commented Feb 16, 2024

I do not think that running an experiment would work as a test.
Instead I would create a fixture that prevents proc.run() for doing anything.
Would this could work as a test?

@lewisblake
Copy link
Member

lewisblake commented Feb 19, 2024

We do have configs which we currently use in CI https://github.com/metno/pyaerocom/blob/main-dev/tests/fixtures/aeroval/cfg_test_exp1.py. Creating a fixture that prevents proc.run() for doing anything could be a good way to test it without adding too much compute time to CI.

@heikoklein
Copy link
Member

The idea of having a proper command-line interface matches very well the with Usability Guidelines for AeroTools. We haven't decided on a proper configuration-format yet, and json is rather a data-transfer format that a configuration language, in particular since readability is not enforced, and comments are not part of the json standard.
Since we have already json-files which can be used for configuration, please call the the cli something like aeroval_json rather than calling it the aeroval config.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@avaldebe avaldebe merged commit 43d140d into main-dev Feb 26, 2024
21 checks passed
@avaldebe avaldebe deleted the pyaeroval-cli branch March 15, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-friendliness Updates that improve ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants