rose edit: speed up adding/deleting sections #1758
Conversation
benfitzpatrick
force-pushed
the
rose-edit.speedup-summary-sections
branch
from
fb4488e
to
fd6180c
Compare
|
@matthewrmshin, please review. |
|
Change looks sane to me, and does not appear to break the new syntax test. I'd prefer if this branch can be re-based merge, because it is very old. @stevewardle as discussed, please review and test. |
| @@ -434,16 +440,23 @@ def get_ns_ignored_status(self, namespace): | |||
| status_counts = object_statuses.items() | |||
| status_counts.sort(lambda x, y: cmp(x[1], y[1])) | |||
| if not status_counts: | |||
There was a problem hiding this comment.
It seems as though cache[namespace] is being set on a few more lines than it really needs to be here (actually above this point as well but it's clearest in this section) - for instance it could appear once after L445 instead of on L447,L450 and L452
There was a problem hiding this comment.
Yes, good point
benfitzpatrick
force-pushed
the
rose-edit.speedup-summary-sections
branch
from
fd6180c
to
525315c
Compare
|
Rebased |
|
Based on testing this on a fairly typical UM app - it's definitely faster at what it's doing. However I notice that the blue |
|
OK, I've removed the change that led to the indicators not showing. The other changes are independent and should still lead to good speedup. We'll have to address the STASH panel behaviour in another pull request, because I think it can be sped up much more. |
|
I've had a look again and it seems like the issue above is resolved |
…y-sections rose edit: speed up adding/deleting sections
This speeds up
rose edit, particularly for adding and deleting sections.When deleting or adding sections in one of the summary panel windows
(including the custom STASH widget) the speed up can be around 2x -
larger or smaller depending on the total number of sections in a configuration.
The change works by caching the slower function calls in the post-change updating,
and by avoiding expensive treeview re-drawing when there's no change.