Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClojureScript compiler warnings #170

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Fix ClojureScript compiler warnings #170

merged 2 commits into from
Nov 8, 2018

Conversation

miikka
Copy link
Contributor

@miikka miikka commented Nov 8, 2018

Miikka Koskinen added 2 commits November 8, 2018 10:00
Do not use cljs.string/replace-all, it's private
65886c1 
The 1.10.439 release of compiler complains about it. Fixes #169.
In ClojureScript, satisfies? is a macro
1a13a24 
Thus `partial` can't be used with it.
@miikka miikka merged commit 102e22a into master Nov 8, 2018
@miikka miikka deleted the fix-169 branch July 28, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikitommi ikitommi ikitommi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miikka @ikitommi