Relax atomic operations of update_gauge and increment_counter - #184
Merged
Conversation
This commit relaxes the atomics of the aforementioned functions, removing the sync pressure on machines with large numbers of CPUs or ARM. As the reads of counters and gauges were formerly relaxed I believe this maintains the semantic intentions, though it is now possible for a writer to immediately read and "lose" the write temporarily if the read is done from a different CPU, in the case of the counter. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
tobz
requested changes
Mar 16, 2021
tobz
left a comment
tobz
left a comment
Member
There was a problem hiding this comment.
This all seems reasonable; just a single spot we need to tweak.
tobz
approved these changes
Mar 16, 2021
Member
|
Merged. Thanks for you contribution! |
mnpw
pushed a commit
to mnpw/metrics
that referenced
this pull request
Mar 8, 2024
Relax atomic operations of `update_gauge` and `increment_counter`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit relaxes the atomics of the aforementioned functions, removing the sync pressure on machines with large numbers of CPUs or ARM. As the reads of counters and gauges were formerly relaxed I believe this maintains the semantic intentions, though it is now possible for a writer to immediately read and "lose" the write temporarily if the read is done from a different CPU, in the case of the counter.
I noticed this while digging through vectordotdev/vector#6770. I haven't managed to test in our project because of vectordotdev/vector#6412.
Signed-off-by: Brian L. Troutwine brian@troutwine.us