Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics crate and investigate performance degradation #6412

Closed
fanatid opened this issue Feb 10, 2021 · 2 comments
Closed

Update metrics crate and investigate performance degradation #6412

fanatid opened this issue Feb 10, 2021 · 2 comments
Assignees
@pablosichert
Labels
domain: deps Anything related to Vector's dependencies domain: observability Anything related to monitoring/observing Vector
Milestone
2021-02-01 D-Fuel

Comments

@fanatid
Copy link
Contributor

fanatid commented Feb 10, 2021 •
edited by binarylogic

Our benchmarks show that upgrading the metrics crate to v0.13.1 causes a significant performance regression (>20%). We need to investigate and resolve the performance problem before we can upgrade.

PR with an attempted update: #6217 (comment)
@fanatid fanatid added the domain: deps Anything related to Vector's dependencies label Feb 10, 2021
@binarylogic binarylogic added the domain: observability Anything related to monitoring/observing Vector label Feb 10, 2021
@binarylogic binarylogic added this to the 2021-02-01 D-Fuel milestone Feb 10, 2021
@pablosichert
Copy link
Contributor

For #5874 we need to upgrade to metrics 0.14.x to be able to use layers::AbsoluteLayer from metrics-util 0.6.1. That's a good opportunity to look if the version bump fixed some of the regressions.

@pablosichert pablosichert mentioned this issue Feb 10, 2021
Merged
@binarylogic binarylogic changed the title Update metrics crates Update metrics crate and investigate performance degradation Feb 13, 2021
@binarylogic binarylogic mentioned this issue Feb 13, 2021
Closed
@pablosichert pablosichert mentioned this issue Feb 14, 2021
Closed
@blt blt mentioned this issue Mar 15, 2021
Merged
@jszwedko
Copy link
Member

Closing this since we did go through with the upgrade in #7031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablosichert pablosichert

Labels
domain: deps Anything related to Vector's dependencies domain: observability Anything related to monitoring/observing Vector
Projects
None yet
Milestone
2021-02-01 D-Fuel
Development

Successfully merging a pull request may close this issue.

chore(metrics): Upgrade metrics crate and crates that transitively depend on it vectordotdev/vector
4 participants
@jszwedko @binarylogic @fanatid @pablosichert