Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review: init.js #533

Closed
hamilton opened this issue Oct 27, 2015 · 0 comments
Closed

code review: init.js #533

hamilton opened this issue Oct 27, 2015 · 0 comments
Assignees
@hamilton
Labels
code quality test
Milestone
v2.8

Comments

@hamilton
Copy link
Collaborator

Part of an ongoing series to improve the code climate GPA, which is a silly metric, but better than no metric.

  • decompose code
  • [edit] refactor decomposed functions
  • [edit] run through semistandard
  • write tests for components
@hamilton hamilton self-assigned this Oct 27, 2015
@hamilton hamilton added this to the v2.8 milestone Oct 27, 2015
hamilton added a commit that referenced this issue Oct 27, 2015
@hamilton
first steps towards #533
4c84bcb
hamilton added a commit that referenced this issue Oct 27, 2015
@hamilton
more toward #533
d0162e3
hamilton added a commit that referenced this issue Oct 27, 2015
@hamilton
more toward #533 - began adding more tests. Much more to do.
b963fac
@hamilton hamilton mentioned this issue Oct 28, 2015
Closed
hamilton added a commit that referenced this issue Nov 3, 2015
@hamilton
further work toward #533 - standardized the basic code style.
b799636
hamilton added a commit that referenced this issue Nov 3, 2015
@hamilton
more tests for #533.
2d3c028
@hamilton hamilton closed this as completed Nov 3, 2015
@hamilton hamilton mentioned this issue Nov 3, 2015
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamilton hamilton

Labels
code quality test
Projects
None yet
Milestone
v2.8
Development

No branches or pull requests
1 participant
@hamilton