Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review: markers.js #541

Closed
4 tasks done
hamilton opened this issue Nov 3, 2015 · 0 comments
Closed
4 tasks done

code review: markers.js #541

hamilton opened this issue Nov 3, 2015 · 0 comments
Assignees
@hamilton
Labels
code quality test
Milestone
v2.8

Comments

@hamilton
Copy link
Collaborator

hamilton commented Nov 3, 2015

Same type of task as #533, following the precedent being set by #534. This on should be a bit easier.

  • decompose code
  • refactor components
  • make code format uniform
  • write tests for components / refactor accordingly
@hamilton hamilton self-assigned this Nov 3, 2015
@hamilton hamilton added this to the v2.8 milestone Nov 3, 2015
hamilton added a commit that referenced this issue Nov 3, 2015
@hamilton
made it through decomposition effort for #541
baeb2e3
hamilton added a commit that referenced this issue Nov 3, 2015
@hamilton
through #541 considering making some generic functions of where certa…
ae06828 
…in elements should exist on a graph, such as the plot bounds
@hamilton hamilton closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamilton hamilton

Labels
code quality test
Projects
None yet
Milestone
v2.8
Development

No branches or pull requests
1 participant
@hamilton