Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No jquery - fix #132 #267

Closed
wants to merge 3 commits into from

Conversation

@soyuka
Copy link

commented Dec 11, 2014

#132

Do not merge this, atm it's only to share the work done as it's beeing commited.

Antoine Bluchet added 2 commits Dec 2, 2014
Antoine Bluchet
fix(charts): Removed jquery occurences in charts
This also adds scope for the dom element and the d3 object to avoid
repetition
@soyuka soyuka referenced this pull request Dec 11, 2014
@soyuka

This comment has been minimized.

Copy link
Owner

commented on src/common/y_axis.js in 88845cd Dec 11, 2014

Is this wanted?

This comment has been minimized.

Copy link

replied Jan 7, 2015

We can remove that. @hamilton is planning to rework the bar chart soon.

@soyuka

This comment has been minimized.

Copy link
Owner

commented on src/common/chart_title.js in 88845cd Dec 11, 2014

everyone does not use awesome font (same below search for @todo)

This comment has been minimized.

Copy link

replied Jan 7, 2015

Fair point.

@benschwarz

This comment has been minimized.

Copy link

commented Jan 3, 2015

This is looking pretty great so far @soyuka

@almossawi

This comment has been minimized.

Copy link

commented on src/misc/error.js in 88845cd Jan 7, 2015

Indeed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.