IHE gateway V2: Zod Validation and Typing Responses #2032

jonahkaye · 2024-05-07T14:40:01Z

Ticket: #1667

Dependencies

Downstream: feat(gender): Adding support for Other & Unknown #2263

Description

zod validation of inbound iti responses and adding typing throughout processing

Testing

Local
- unit tests
- local flow
Staging
- tested to staging

Release Plan

Merge this

Refs: #1667

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dq-response.ts

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye · 2024-06-05T18:48:38Z

packages/utils/src/saml/saml-server.ts

remove this

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye · 2024-06-05T19:28:12Z

...c/external/carequality/ihe-gateway-v2/outbound/__tests__/xmls/xcpd_match_multi_addr_name.xml

+                                    <name>
+										<family partType="FAM">NWHINZZZTESTPATIENT</family>
+										<given partType="GIV">NWHINONE</given>
+									</name>


adding test for where name is in different format which we saw in prod

jonahkaye · 2024-06-05T19:28:34Z

packages/core/src/external/carequality/ihe-gateway-v2/outbound/schema.ts

shared schemas

jonahkaye · 2024-06-05T19:29:12Z

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dq-response.ts


  const findSlotValue = (name: string): string | undefined => {
    const slot = slots.find((slot: Slot) => slot._name === name);
-    return slot
-      ? Array.isArray(slot.ValueList.Value)


ValueList.Value is never an array so removing this

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/schema.ts

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

RamilGaripov

Approved on the condition that my comments are addressed

packages/core/src/external/carequality/ihe-gateway-v2/outbound/__tests__/process-dr.test.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dq-response.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/schema.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/error.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts

packages/core/src/external/carequality/ihe-gateway-v2/utils.ts

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts

packages/utils/src/saml/pre-prod-tester.ts

leite08

handleSchemaErrorResponse(): I see we're not logging or doing anything w/ the information that we had a schema parsing error - shouldn't we?

packages/api/src/routes/medical/dtos/demographicsDTO.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/schema.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dr-response.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/schema.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/error.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

packages/api/src/routes/medical/dtos/patientDTO.ts

packages/core/src/domain/patient.ts

leite08

Leaving a few comments.

Missed this one:

handleSchemaErrorResponse(): I see we're not logging or doing anything w/ the information that we had a schema parsing error - shouldn't we?

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts

packages/core/src/external/fhir/patient/index.ts

jonahkaye · 2024-06-13T17:07:14Z

Leaving a few comments.

Missed this one:

handleSchemaErrorResponse(): I see we're not logging or doing anything w/ the information that we had a schema parsing error - shouldn't we?

4899def addressed in this commit

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

leite08

LGTM, approving considering we can address the couple of small comments. 🚀

packages/api/src/routes/medical/dtos/demographicsDTO.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dq-response.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dr-response.ts

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts

feat(ihev2): dq schema

be10a06

Refs: #1667

jonahkaye changed the title ~~feat(ihev2): dq schema~~ IHE gateway V2: Zod Validation and Typing Responses May 7, 2024

jonahkaye commented May 8, 2024

View reviewed changes

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xca/process/dq-response.ts Show resolved Hide resolved

feat(ihev2): develop to branch

de3ab34

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye commented Jun 5, 2024

View reviewed changes

packages/utils/src/saml/saml-server.ts Outdated

Copy link

Member Author

jonahkaye Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

jonahkaye added 3 commits June 5, 2024 15:05

feat(ihev2): dq zod schema

c665b5f

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

feat(ihev2): dr zod schema

83ce629

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

feat(ihev2): xcpd zod schema

c3444c3

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye force-pushed the 1667-zod-validation-iti-response-refactor branch 2 times, most recently from f5ffc2e to fb98d4e Compare June 5, 2024 19:25

jonahkaye commented Jun 5, 2024

View reviewed changes

packages/core/src/external/carequality/ihe-gateway-v2/outbound/schema.ts

Copy link

Member Author

jonahkaye Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared schemas

jonahkaye commented Jun 5, 2024

View reviewed changes

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts Show resolved Hide resolved

jonahkaye commented Jun 5, 2024

View reviewed changes

packages/core/src/external/carequality/ihe-gateway-v2/outbound/schema.ts Outdated Show resolved Hide resolved

feat(ihev2): refactor zod schema

e939ec7

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye force-pushed the 1667-zod-validation-iti-response-refactor branch from 1085759 to e939ec7 Compare June 5, 2024 19:46

jonahkaye self-assigned this Jun 5, 2024

jonahkaye marked this pull request as ready for review June 5, 2024 19:48

jonahkaye requested review from Goncharo, leite08, Orta21 and RamilGaripov as code owners June 5, 2024 19:48

feat(ihev2): merge develop to branch

f1fede7

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

RamilGaripov approved these changes Jun 7, 2024

View reviewed changes

feat(ihe): updating xcpd, dq, dr schemas + xcpd testing framework

6ad9752

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye force-pushed the 1667-zod-validation-iti-response-refactor branch from d03bba8 to 6ad9752 Compare June 11, 2024 00:14

feat(ihe): nit

b035990

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

jonahkaye commented Jun 11, 2024

View reviewed changes

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts Outdated Show resolved Hide resolved

jonahkaye commented Jun 11, 2024

View reviewed changes

packages/utils/src/saml/pre-prod-tester.ts Outdated Show resolved Hide resolved

leite08 reviewed Jun 11, 2024

View reviewed changes

jonahkaye added 2 commits June 11, 2024 14:45

feat(ihe): nits

2dbf7bc

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

feat(ihe): filtering empty strings to undefined

f6e1578

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

leite08 reviewed Jun 12, 2024

View reviewed changes

packages/api/src/routes/medical/dtos/patientDTO.ts Outdated Show resolved Hide resolved

packages/core/src/domain/patient.ts Outdated Show resolved Hide resolved

leite08 reviewed Jun 12, 2024

View reviewed changes

packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/schema.ts Show resolved Hide resolved

packages/core/src/external/fhir/patient/index.ts Outdated Show resolved Hide resolved

jonahkaye mentioned this pull request Jun 13, 2024

feat(gender): Adding support for Other & Unknown #2263

Merged

6 tasks

jonahkaye force-pushed the 1667-zod-validation-iti-response-refactor branch 2 times, most recently from 4899def to f6e1578 Compare June 14, 2024 02:48

jonahkaye added 2 commits June 13, 2024 23:06

feat(ihe): removing gender logic and adding logging for schema errors

0f2e9fb

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

feat(ihe): removing last gender logic

af23860

Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>

leite08 approved these changes Jun 14, 2024

View reviewed changes

jonahkaye added this pull request to the merge queue Jun 14, 2024

Merged via the queue into develop with commit bb9e532 Jun 14, 2024
13 checks passed

jonahkaye deleted the 1667-zod-validation-iti-response-refactor branch June 14, 2024 13:58

jonahkaye mentioned this pull request Jun 14, 2024

RELEASE 2024_06_14 IHE Zod Schemas #2275

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IHE gateway V2: Zod Validation and Typing Responses #2032

IHE gateway V2: Zod Validation and Typing Responses #2032

jonahkaye commented May 7, 2024 •

edited

Loading

jonahkaye Jun 5, 2024

jonahkaye Jun 5, 2024

jonahkaye Jun 5, 2024

jonahkaye Jun 5, 2024

RamilGaripov left a comment

leite08 left a comment

leite08 left a comment

jonahkaye commented Jun 13, 2024

leite08 left a comment

IHE gateway V2: Zod Validation and Typing Responses #2032

IHE gateway V2: Zod Validation and Typing Responses #2032

Conversation

jonahkaye commented May 7, 2024 • edited Loading

Dependencies

Description

Testing

Release Plan

jonahkaye Jun 5, 2024

Choose a reason for hiding this comment

jonahkaye Jun 5, 2024

Choose a reason for hiding this comment

jonahkaye Jun 5, 2024

Choose a reason for hiding this comment

jonahkaye Jun 5, 2024

Choose a reason for hiding this comment

RamilGaripov left a comment

Choose a reason for hiding this comment

leite08 left a comment

Choose a reason for hiding this comment

leite08 left a comment

Choose a reason for hiding this comment

jonahkaye commented Jun 13, 2024

leite08 left a comment

Choose a reason for hiding this comment

jonahkaye commented May 7, 2024 •

edited

Loading