Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kubeconfig persist logic #412

Merged
merged 5 commits into from Dec 18, 2019
Merged

Conversation

metrue
Copy link
Owner

@metrue metrue commented Dec 17, 2019

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #412 into master will increase coverage by 0.04%.
The diff coverage is 40.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   33.98%   34.03%   +0.04%     
==========================================
  Files          48       48              
  Lines        2189     2192       +3     
==========================================
+ Hits          744      746       +2     
+ Misses       1327     1326       -1     
- Partials      118      120       +2
Impacted Files Coverage Δ
handlers/infra.go 0% <0%> (ø) ⬆️
middlewares/provision.go 0% <0%> (ø) ⬆️
infra/k8s/cloud.go 54.9% <53.12%> (-0.3%) ⬇️
config/config.go 40.81% <60%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d868ebf...97fa580. Read the comment docs.

Signed-off-by: Minghe Huang <h.minghe@gmail.com>
Signed-off-by: Minghe Huang <h.minghe@gmail.com>
Signed-off-by: Minghe Huang <h.minghe@gmail.com>
@metrue metrue merged commit 1f7714c into master Dec 18, 2019
@metrue metrue deleted the refactor-kubeconfig-persist branch December 18, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant