Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support before_build hook #455

Merged
merged 7 commits into from Feb 11, 2020
Merged

support before_build hook #455

merged 7 commits into from Feb 11, 2020

Conversation

metrue
Copy link
Owner

@metrue metrue commented Feb 10, 2020

Issue: #454
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

hook/hook_manager.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #455 into master will decrease coverage by 8.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   34.74%   26.23%   -8.51%     
==========================================
  Files          50       52       +2     
  Lines        2222     2287      +65     
==========================================
- Hits          772      600     -172     
- Misses       1326     1567     +241     
+ Partials      124      120       -4     
Impacted Files Coverage Δ
infra/k8s/init_container.go 0.00% <0.00%> (-100.00%) ⬇️
infra/k8s/deployment.go 0.00% <0.00%> (-93.19%) ⬇️
infra/k8s/service.go 0.00% <0.00%> (-89.19%) ⬇️
infra/k8s/pod.go 0.00% <0.00%> (-83.34%) ⬇️
infra/k8s/configmap.go 0.00% <0.00%> (-65.22%) ⬇️
infra/k8s/deployer.go 0.00% <0.00%> (-29.81%) ⬇️
middlewares/binding.go 38.70% <0.00%> (-29.04%) ⬇️
hook/hook_manager.go 62.96% <0.00%> (ø)
hook/hook.go 68.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3e857...422035b. Read the comment docs.

@metrue metrue merged commit bdc454e into master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant