-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom file names #171
Conversation
previously didn't have cpu file:
now picks up cpu file:
no need to suppress grd file for SAEM/IMP + now includes cpu_time
which matches up to the total CPU time:
|
Running a model with no grd and shk files we can see:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don't see where you tested giving it a custom ext name, but I see it in the code.
Not sure what the testing/merging regime is for bbi/Go but I guess merge and build this if you feel good about it and I'll test it further through rbabylon.
This cleans up the file handling around summary file needs significantly, including some nomenclature fixes, adjustment of flag positions and a fix when using SAEM/IMP to not fail with missing gradient file (it shouldn't be present then).