Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parameter_list objects to be passed to param #1076

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Apr 7, 2023

See discussion in #1075 : a user tried to do this in code and it didn't work; no reason why it shouldn't work.

This PR enables the user to pass a parameter_list object to update parameters in a model object via param()

library(dplyr)
library(mrgsolve)

mod <- house()

mod %>% param(param(CL = 5)) %>% param()

@kylebaron kylebaron added the bug label Apr 7, 2023
@kylebaron kylebaron added this to the v1.1.0 milestone Apr 7, 2023
@kylebaron kylebaron added this to Implement in Development Apr 7, 2023
@kylebaron kylebaron moved this from Implement to Evaluate in Development Apr 7, 2023
@kylebaron kylebaron requested a review from kyleam May 2, 2023 23:53
Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Confirmed that the new test fails when the code change is reverted.

@kylebaron kylebaron merged commit 457d8ce into main May 4, 2023
Development automation moved this from Evaluate to Done May 4, 2023
@kylebaron kylebaron deleted the param/param branch May 4, 2023 03:47
@kylebaron kylebaron mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants