Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mevent hx reset #1118

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Fix mevent hx reset #1118

merged 4 commits into from
Nov 14, 2023

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Sep 30, 2023 •
edited

Summary

We should clear the mtime event history with every subject but only if mtime is being used. Details in #1117

@kylebaron kylebaron added this to the Next Version milestone Sep 30, 2023
@kylebaron kylebaron linked an issue Sep 30, 2023 that may be closed by this pull request
mevent history doesn't get cleaned up properly #1117
Closed
@kylebaron kylebaron removed this from the Next Version milestone Nov 4, 2023
@kylebaron kylebaron removed a link to an issue Nov 8, 2023
mevent history doesn't get cleaned up properly #1117
Closed
@kylebaron kylebaron added the bug label Nov 8, 2023
@kylebaron kylebaron linked an issue Nov 8, 2023 that may be closed by this pull request
mevent history doesn't get cleaned up properly #1117
Closed
@kylebaron kylebaron requested a review from kyleam November 8, 2023 16:34
kyleam
kyleam approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/devtran.cpp fix looks good to me. Verified regression test and reproducer from gh-1117 behave as expected before and after code change.

@kylebaron kylebaron merged commit c52292b into main Nov 14, 2023
@kylebaron kylebaron deleted the fix/hx-reset branch November 14, 2023 06:15
@kylebaron kylebaron mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleam kyleam kyleam approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mevent history doesn't get cleaned up properly
2 participants
@kylebaron @kyleam