Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never ignore .now doses based on .time #1152

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Never ignore .now doses based on .time #1152

merged 3 commits into from
Jan 10, 2024

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Jan 6, 2024 •
edited

  • Doses that are requested with time before the current time are ignored.
  • When doses are scheduled to happen now, it shouldn't matter what the value of time is in the object passed back to mrgsolve
  • That is to say, we want now status to override whatever is in time

This PR corrects some of the implementation logic so we don't ignore them when the dose is to be given now.

See #1151

@kylebaron kylebaron linked an issue Jan 6, 2024 that may be closed by this pull request
ev.now events not executed when ev.time is prior to current time #1151
Closed
@kylebaron kylebaron requested a review from kyleam January 8, 2024 14:48
@kylebaron kylebaron merged commit 8ea7d8e into main Jan 10, 2024
@kylebaron kylebaron deleted the fix/ev-now-time branch January 10, 2024 14:08
@kylebaron kylebaron mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleam kyleam kyleam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ev.now events not executed when ev.time is prior to current time
2 participants
@kylebaron @kyleam