Error when k10 is equal to ka in one-compartment closed-form model #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
approved these changes
Jun 28, 2024
| @@ -380,6 +380,12 @@ void odeproblem::advan2(const double& tfrom, const double& tto) { | |||
|
|
|||
| if(k10 <= 0) Rcpp::stop("k10 has a 0 or negative value"); | |||
|
|
|||
| // Going for the simpler method; using epsilon of ~ 100 * DBL_EPSILON | |||
| // https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/ | |||
| if(std::fabs(ka-k10) < 2.22e-14) { | |||
There was a problem hiding this comment.
I think this approach makes sense here.
Just a note:isSymmetric.matrix uses 100 * DBL_EPSILON as its default value too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For closed-form solution to one-compartment model, error when KA and CL/V are too close together.