Add replace() function to evtools #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebaron
commented
Jun 22, 2024
| @@ -49,7 +49,7 @@ struct resim { | |||
| }; | |||
|
|
|||
| struct evdata { | |||
| evdata(double a_, int b_) : time(a_), evid(b_) { | |||
| evdata(double a_, int b_) : time(a_), evid(b_) { | |||
kylebaron
commented
Jun 22, 2024
| @@ -34,6 +34,21 @@ void infuse(databox& self, const double amt, const int cmt, const double rate) { | |||
| return; | |||
| } | |||
|
|
|||
| mrgsolve::evdata replace(const double amt, const int cmt) { | |||
| mrgsolve::evdata ev(0, 8); | |||
There was a problem hiding this comment.
The signature for the constructor is time and evid. We use 8 here because that signals to zero out the compartment and add the new amount. The time value (0) is arbitrary b/c we'll set the object to get implemented now later on.
kylebaron
changed the title
kyleam
approved these changes
Jul 3, 2024
| after <- filter(a, time >= 5) | ||
| expect_true(all(after$C==50)) | ||
|
|
||
| #' When the replacement is timed into the future, we see the |
There was a problem hiding this comment.
extreme nit-pick: I think it'd be better to use plain comments rather than roxygen-style ones. (I've been allergic to unnecessary roxygen-style comments ever since I spent time debugging this issue.)
There was a problem hiding this comment.
Thanks, @kyleam; I reverted the comments and will try to stick to plain R comments going forward (I think I do most of the time, but I'm sure there's tons of #' comments in the code too.)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To date, the
evtoolsplugin has been able to quickly create and give doses given asbolus()orinfuse().This PR implements an equivalent function to
replace()the amount in a specific compartment with a new amount. This is accomplished viaevid 8(already-existing functionality).The basic setup is similar to
bolus()andinfuse(): we provide two overloadedreplace()functions, one that gets theselfobject first (this will create and "send" the dose in one function call) and anotherreplace()function that will create the object and return it to the user for further config.