Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.releaseignore / make release excludes too much files #1048

Open
dearith opened this issue Jan 6, 2021 · 1 comment
Open

.releaseignore / make release excludes too much files #1048

dearith opened this issue Jan 6, 2021 · 1 comment

Comments

@dearith
Copy link
Contributor

dearith commented Jan 6, 2021

I think the rules followed by .releaseignore are not correct, thus too much files are ignored.

My use case :

A plugin foo.

The root plugin directory contains a coverage_info.md file

Under the root plugin directory, there is a template directory containing a template_describe_coverage.csv file.

The .releaseignore file (in the root directory) is :

# don't add python3_virtualenv_sources here as we need it for installing
# (it will be removed just after install)
# don't add python2_virtualenv_sources here as we need it for installing
# (it will be removed just after install)
/local
/src
/doc
/docs
__pycache__
*.pyc
.git
.svn
.git*
*.plugin
Makefile
/test
.coveragerc
coverage*
sonar-project.properties

With coverage* in the .releaseignore, i just want to exclude files starting with 'coverage'

When I run make release and install my plugin, the coverage_info.md file is missing (that's correct), but the template_describe_coverage.csv file is also missing in the template directory (that's not correct).

Perhaps it's not a bug, but in this case .releaseignore doesn't work like git and .gitignore.

If I try to do the same with git and .gitignore, only coverage_info.md is ignored by git (regardless of the directory where the file is located).

Notice if I set /coverage* instead of coverage*, in the .releaseignore , that works, only coverage_info.md is excluded.

@thefab
Copy link
Member

thefab commented Jan 8, 2021

we use https://github.com/mherrmann/gitignore_parser for parsing this file

so, it should behave like .gitignore!

It's probably a bug of this library. I found:
mherrmann/gitignore_parser#10

there is a conflicting PR about that

as it's a minor issue, I propose to wait a little bit to see in the problem is fixed upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants