Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1178 patterns with negation, change the way to apply results of .releaseignore file #14

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

albator75
Copy link
Contributor

@albator75 albator75 commented Aug 17, 2021

I think this change will apply accuretly results of .releaseignore.
Tested with some exemples. If needed, i could push the tests...

However, it doesn't fix #1048

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Olivier MILLAN seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@albator75 albator75 changed the title correction for #1178 : patterns with negation, change the way to apply results of .releaseignore file fix #1178 : patterns with negation, change the way to apply results of .releaseignore file Aug 17, 2021
@thefab thefab self-requested a review August 17, 2021 12:48
@thebaptiste thebaptiste requested review from matthieumarrast and removed request for thefab January 3, 2023 14:23
@matthieumarrast
Copy link
Contributor

Tested OK.
And indeed it does not fix metwork-framework/mfext#1048

@mergify
Copy link

mergify bot commented Jan 3, 2023

For mergify to merge automatically this PR,

=> you have to change the PR title to match conventional commit specification:

regex: ^(build|chore|ci|docs|style|refactor|perf|test|fix|feat|fix|feat|feat!|fix!)(\([a-z]+\))?: .*$

As the title will be used for the commit message (and so for changelog entry if feat: or fix:).

@thebaptiste thebaptiste changed the title fix #1178 : patterns with negation, change the way to apply results of .releaseignore file fix: #1178 patterns with negation, change the way to apply results of .releaseignore file Jan 4, 2023
@mergify mergify bot merged commit ef1a134 into metwork-framework:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.releaseignore / make release : incorrect exclusion with lines beginning with !
3 participants