Support Laravel 6.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SQL error "key" is ambiguous
@getDuplicatesQuery used "id" directly as primary key for the model. Changed to "{keyName}" notation. :-)
Remove hardcoded refs to "id" as PK
Fixes the join problem
Support Laravel 5.7
…ndantOf with additional join(s) If joins are made between the table using the NodeTrait and the table itself, using conditions whereDescendantOf or whereAncestorOf would throw an Integrity Constraint Violation error on columns _lft and/or _rgt.
Fix "ambiguous column" issue when using ancestor/descendant condition
Support Laravel 5.8
Due to some changes in the Laravel internals in regard with handling eager loading, upgrading the library to Laravel 5.7 is required. Also, nobody should be on PHP < 7 anyway. So now is a good time, if any...
…zychaser#339, lazychaser#351, lazychaser#329, lazychaser#334, lazychaser#271) The way eager loading is handled in Laravel has changed since the original implementation of the NestedSet library. It was not possible anymore to apply the scope to eagerly loaded ancestors/descendants relationships. Also removed defaultOrder() from the relations so custom orders can be applied. Sorting should never be a part of a relation anyway, or it would be hard to customize.
V5 - fix support for Laravel 5.7 and 5.8 (fixes lazychaser#339, lazychaser#351, lazychaser#329, lazychaser#334, lazychaser#271, lazychaser#365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.