This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1622257.
APIv8 docs have been merged, so choo choo 🚂 |
feature: Guild templates
…json object so no deserialization needed. Maybe in future direct fetch of role, channel and user ids.
…ommandInteractionDataOption.java Co-authored-by: amy null <null@amy.gg>
…id schould be fetched in the future maybe
Fixed type read out of InteractionDataOption and added the value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
New feature or request
new discord feature
New feature Discord is adding; may need time before adding support
v3
Marks issues/PRs specifically about v3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this makes some backwards-incompatible changes, this is a major version bump.
This is a WIP based off of discord/discord-api-docs#2097.
Note: The branch name is a little funny because I had started on v8 work, then realised it was full of breaking changes, so figured I'd do a version bump, so...
An overview of changes
Maybe
instead ofSingle
where it makes sense.RxHelpers
to await a lot ofMaybe
s andSingle
s.Message#reply()
.RestChannel#sendMessage()
to#createMessage()
to match what's in the docs properly.Member#mute()/deaf()
(Member#mute()/deaf() don't work #489).DoubleEvent
exceptions.CHANNEL_UPDATE
is now aDoubleEvent
the way it should have been.Catnip#on()
is nowprivate
, to push people towards using Rx operators properly.Q. Why does
<this method>
return an Rx operator, but<that method>
returns an entity class?A. This is due to how the Discord API works, and the points at which it does/not actually provide an entity.
Q. Returning Rx operators for every cache method is stupid and painful and bad you absolute moron.
A. That's not really a question, but unless you're doing some special caching stuff, you can wrap them in methods that block, or just use
#blockingGet()
everywhere, or... to get the old blocking behaviour. The reason for it being this way is because ex. a remote entity cache in Redis shouldn't block during the network round trips.